Skip to content

Conversation

@hichamboushaba
Copy link
Member

@hichamboushaba hichamboushaba commented Sep 10, 2025

Closes WOOMOB-1184

Description

This PR adds a new tag to Zendesk requests when the current site is a Jetpack site that supports using app passwords.

Steps to reproduce

  1. Use a site that supports app passwords.
  2. Sign in using WordPress.com
  3. Create a support ticket from the app (from the menu Settings > Support ).

Testing information

  • Confirm the ticket created in the above scenario includes the tag jetpack_site_using_app_passwords
  • Confirm tickets created for other sites don't include the tag.

The tests that have been performed

The above.

  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

@hichamboushaba hichamboushaba added type: task An internally driven task. feature: support Related to anything in the help & support section, including app logs and the Zendesk SDK. unit-tests-exemption labels Sep 10, 2025
@hichamboushaba hichamboushaba added this to the 23.3 milestone Sep 10, 2025
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Sep 10, 2025

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commitc2b95b7
Direct Downloadwoocommerce-wear-prototype-build-pr14599-c2b95b7.apk

@hichamboushaba hichamboushaba force-pushed the issue/WOOMOB-1184-jp-app-passwords-support-tag branch from feae823 to fc7b2d9 Compare September 10, 2025 15:54
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Sep 10, 2025

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commitc2b95b7
Direct Downloadwoocommerce-prototype-build-pr14599-c2b95b7.apk

@hichamboushaba hichamboushaba force-pushed the issue/WOOMOB-1184-jp-app-passwords-support-tag branch from fc7b2d9 to c2b95b7 Compare September 10, 2025 17:45
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 73.91304% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 38.33%. Comparing base (c5653a0) to head (c2b95b7).
⚠️ Report is 54 commits behind head on trunk.

Files with missing lines Patch % Lines
...passwords/IsAppPasswordsSupportedForJetpackSite.kt 0.00% 5 Missing ⚠️
...android/support/zendesk/ZendeskTicketRepository.kt 94.44% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##              trunk   #14599   +/-   ##
=========================================
  Coverage     38.33%   38.33%           
  Complexity     9686     9686           
=========================================
  Files          2057     2058    +1     
  Lines        115151   115166   +15     
  Branches      15312    15315    +3     
=========================================
+ Hits          44144    44153    +9     
- Misses        66934    66939    +5     
- Partials       4073     4074    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@AdamGrzybkowski AdamGrzybkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Tested with the Disable Application Password plugin.

AP Enabled AP Disabled
Screenshot 2025-09-11 at 15 44 10 Screenshot 2025-09-11 at 15 40 13

@AdamGrzybkowski AdamGrzybkowski merged commit b734542 into trunk Sep 11, 2025
18 checks passed
@AdamGrzybkowski AdamGrzybkowski deleted the issue/WOOMOB-1184-jp-app-passwords-support-tag branch September 11, 2025 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: support Related to anything in the help & support section, including app logs and the Zendesk SDK. type: task An internally driven task. unit-tests-exemption

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants